Bug #14068

beta EH fired (select 6)

Added by dead3yez over 4 years ago. Updated over 4 years ago.

Status:Closed Start date:09/29/2010
Priority:Normal Due date:
Assignee:killswitch % Done:

100%

Category:XEH
Target version:v0.7.0
Component: Affected Version:
Close Reason:

Description

[73642] New: event handler "fired" returns magazine name and object of projectile.
EH fired returns <NULL>-object for new beta (_this select 6)

Associated revisions

Revision f22713db
Added by Sickboy over 4 years ago

~ ADDED: Support for new Fired EH properties. fixes #14068

Revision f22713db
Added by Sickboy over 4 years ago

~ ADDED: Support for new Fired EH properties. fixes #14068

Revision 55fced2c
Added by Sickboy over 4 years ago

~ CHANGED: FiredEH properties reversed to not break existing XEH scripts. projectile, magazine instead of magazine, projectile. refs #14068

Revision 55fced2c
Added by Sickboy over 4 years ago

~ CHANGED: FiredEH properties reversed to not break existing XEH scripts. projectile, magazine instead of magazine, projectile. refs #14068

Revision 7260e49f
Added by Sickboy over 4 years ago

Author: Sickboy ()

Date: 43 seconds ago (Thu Sep 30 09:02:08 2010 +0200)
Commit hash: e90cb69bca035184455e3eb06808a3fab5705fd0

~ CHANGED: Added magazine to fired eventhandler for OA builds before 73643. refs #14068

Revision 7260e49f
Added by Sickboy over 4 years ago

Author: Sickboy ()

Date: 43 seconds ago (Thu Sep 30 09:02:08 2010 +0200)
Commit hash: e90cb69bca035184455e3eb06808a3fab5705fd0

~ CHANGED: Added magazine to fired eventhandler for OA builds before 73643. refs #14068

History

Updated by Sickboy over 4 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Updated by Sickboy over 4 years ago

  • Category set to XEH
  • Status changed from Resolved to In progress
  • Assignee set to killswitch
  • Target version set to v0.7.0
  • % Done changed from 100 to 90
Thanks! Solved, except that we'll have to decide which format to support in XEH;
  • BIS BETA: unit, weapon, muzzle, mode, ammo, magazine, projectile
  • XEH: unit, weapon, muzzle, mode, ammo, projectile

The projectile shifts position depending if you run the original or the latest beta, and we didn't have the magazine at all before :)

Obviously it would be preferred to stick to BIS's new parameter format, yet all XEH implementations that use the Fired Eventhandler could rely on _projectile = _this select 5 ;-)

Discussion @ https://wave.google.com/wave/waveref/googlewave.com/w+yst6bKikX/~/conv+root/b+lNmwRtrQQ

Updated by dead3yez over 4 years ago

Thanks. Saved a lot of trouble there as I didn't know they shifted.

prehaps: unit, weapon, muzzle, mode, ammo, projectile, projectile

I'll leave that to you.

Updated by Sickboy over 4 years ago

dead3yez wrote:

Thanks. Saved a lot of trouble there as I didn't know they shifted.

Thanks and NP!

prehaps: unit, weapon, muzzle, mode, ammo, projectile, projectile

That would be a possibility, but lacks magazine, we could add at the end obviously, but it would still not be 100% BIS :) But at least 100% XEH Backward compatible :)
Since we would break from default BIS in that case, i'd turn it around;
unit, weapon, muzzle, mode, ammo, projectile, magazine

From backwards compatibility view that would be awesome, just people using the XEH FiredEH would need to account for the reversed working of projectile and magazine compared to the new BIS default.

Updated by Sickboy over 4 years ago

For now implemented; unit, weapon, muzzle, mode, ammo, projectile, magazine
This will keep XEH backwards compatible to the early beginnings.

Updated by Sickboy over 4 years ago

  • Status changed from In progress to Closed
  • % Done changed from 90 to 100

Also available in: Atom PDF